Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] API Requests #43

Closed
Legomix13 opened this issue Jan 15, 2022 · 3 comments
Closed

[Feature Request] API Requests #43

Legomix13 opened this issue Jan 15, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Legomix13
Copy link

Describe the bug
I'm building a web interface to manage the config more visually (will be openly released once finished) but when I try to make a PUT request to the API so I can modify an object I get a CORS error because most of the common web browsers will send first an OPTIONS request to the server but this one is rejecting that request with the message:
{"detail":"Method Not Allowed"}
Is there an easy way to let these request go?

To Reproduce

  • Steps to reproduce the behavior
    • step1: Send a PUT request to any of the API endpoints over a browser
    • step2: Watch console

Actual behavior
The API server refuses the OPTIONS preflight request from the browser

Expected behavior
The server should let pass the OPTIONS and handle CORS

@Legomix13 Legomix13 added the bug Something isn't working label Jan 15, 2022
@hnimminh hnimminh self-assigned this Jan 20, 2022
@hnimminh hnimminh added enhancement New feature or request and removed bug Something isn't working labels Jan 20, 2022
@hnimminh hnimminh changed the title [BUG] API Requests [Feature Request] API Requests Jan 20, 2022
hnimminh added a commit that referenced this issue Jan 20, 2022
@hnimminh
Copy link
Owner

@Legomix13 can you retry with master? I just put new code support to CORS. Thanks

@Legomix13
Copy link
Author

Awesome, I will contact you once I finish the development

Many thanks!

@hnimminh
Copy link
Owner

Well note, I'm exciting to see your UI. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants