This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
New deploy code and contract verification script (+misc) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondees
reviewed
Dec 30, 2021
| @@ -141,6 +141,9 @@ module.exports = { | |||
| }, | |||
| }, | |||
| }, | |||
| // Set API key for etherscan/polygonscan/mumbai.polygonscan | |||
| // Endpoint will be chosed based on default network | |||
| // TODO: Replace this hardcode with a switch on defaultNetwork | |||
| etherscan: { | |||
| apiKey: '43JVMCI3EJCZSECDWX99KRZRYWDX3H7MCH' | |||
There was a problem hiding this comment.
whose key is this? should we go ahead and migrate this to env?
There was a problem hiding this comment.
Not mine :p but it's a block explorer key, strictly read-only.
Yes on the env, there's infura keys in this file and a few other places. Can be a different PR collecting all these keys.
|
Just missing transferring ownership of Root and Oracle contracts to non-deployer account at end of script but i will add that in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
_eth.hardhatpackage to latest version because it fixed something I don't really remember (but I checked to make sure no breaking changes from2.0.8to2.8.0hardhat/deployments/andreact-app/src/contracts/to gitignorenamespaceformumbainetwork in react app constantsDeploying
Instead of a contract or script to handle everything manually, hardhat-deploy looks for deploy scripts in
hardhat/deploys/. Multiple scripts can be added, actions taken pre/post deploy, etc. This PR adds 1 script here:00_deploy_all.js.Notes:
yarn deploy:test. This runsyarn deployand then the publish script that updates frontend's contracts directory.Verification
A new script
scripts/verify-contracts.jsdoes all the work of verifying all contracts on etherscan / polygon / mumbai.polygon / wherever. All you need to do is:node scripts/verify-contracts.jsNotes:
hardhat.config.js(etherscan->apiKey) and run the script, everything's taken care of.