Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STEUN-409): change php requirements #38

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat(STEUN-409): change php requirements #38

merged 1 commit into from
Jun 20, 2023

Conversation

wimvdputten
Copy link
Contributor

Accidentally merged the branch to master without proper PR review.

See PR for individual commits: #36

@wimvdputten wimvdputten self-assigned this Jun 20, 2023
@PascalBrouwers
Copy link
Contributor

Wist niet dat je tegenwoordig 0 moest teruggeven.

@wimvdputten
Copy link
Contributor Author

@PascalBrouwers ,
Nou voor de nieuwe symfony versies moet je een int/error code terug geven.
Vandaar de 0.
Bij symfony v6^ kan ik Command::Succes terug geven, maar dan is deze module niet backwards compatible

@wimvdputten wimvdputten merged commit 54e210e into master Jun 20, 2023
@wimvdputten wimvdputten deleted the revert-37-revert-36-STEUN-409 branch June 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalBrouwers PascalBrouwers PascalBrouwers approved these changes

Assignees

@wimvdputten wimvdputten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wimvdputten @PascalBrouwers