Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/fix drag-and-drop #175

Merged
merged 22 commits into from
Jun 8, 2022

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Mar 16, 2022

Fixes #154

Lmk what you think!

Leave out event-press and grid-press for now
Leave out grid touches for now
Create ViewWithTouchable, patches TouchableWithoutFeedback from RNGH
Reduce from multiple touchables to just one touchable per week
Do not recreate callbacks in each render
Names used: "handleX" for component methods, "onX" for props
@pdpino pdpino added the status: on hold Not addressed yet or waiting other issue label Apr 25, 2022
@pdpino pdpino added status: PR - ready priority: high and removed status: on hold Not addressed yet or waiting other issue labels May 17, 2022
@hoangnm
Copy link
Owner

hoangnm commented Jun 4, 2022

Hi @pdpino, I tried to run on local but the calendar is frozen and I couldn't perform any action, anything specific I need to set up when running on local?

@hoangnm
Copy link
Owner

hoangnm commented Jun 4, 2022

nvm, I can make it work now.

@pdpino
Copy link
Collaborator Author

pdpino commented Jun 4, 2022

@hoangnm only installing peer dependencies react-native-gesture-handler v2 and react-native-reanimated v2, following their instructions

expect(onDragMock).toHaveBeenCalledWith(
mockEvent,
position.left + position.width / 2 + 7,
position.top + 52,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a clear naming for these values?

Copy link
Collaborator Author

@pdpino pdpino Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoangnm updated

@hoangnm
Copy link
Owner

hoangnm commented Jun 4, 2022

Drag & drop are really smoother, this would be a great improvement.

Improve ViewWithTouchable docs
Remove unnecessary key
@hoangnm
Copy link
Owner

hoangnm commented Jun 7, 2022

I'm thinking to use this feature as a version 2 and I'll bump the current code base to v1.

@pdpino
Copy link
Collaborator Author

pdpino commented Jun 7, 2022

Are we following semver?

I'll bump the current code base to v1

I suggest we stay in version 0.x, we can still make some breaking changes

@hoangnm
Copy link
Owner

hoangnm commented Jun 7, 2022

yes, there's a FAQ https://semver.org/#how-do-i-know-when-to-release-100 and I think that recommendation makes sense for our case. WDYT, @pdpino ?

@pdpino
Copy link
Collaborator Author

pdpino commented Jun 7, 2022

Some users might be using in production: yes

But I think the API might still change, e.g. some props:

I prefer keeping 0.x and finish some of these new features first

@hoangnm
Copy link
Owner

hoangnm commented Jun 8, 2022

ok @pdpino , that makes sense.

@hoangnm
Copy link
Owner

hoangnm commented Jun 8, 2022

Great PR, thank @pdpino , merging.

@hoangnm hoangnm merged commit 321ef92 into hoangnm:master Jun 8, 2022
@pdpino pdpino deleted the feature/drag-gesture-handler branch June 8, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to disable horizontal and vertical scrolling when dragging an event somehow
3 participants