Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goToDate() method #56

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Add goToDate() method #56

merged 3 commits into from
Jan 23, 2021

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Nov 2, 2020

Add method to navigate to a specific date, fixes #54

Notes:

  • This is a breaking change (to move to a date). Maybe we could create a changelog documenting this?
  • There is a slight hack with the setTimeout(..., 0) method. This is needed so the child VirtualizedList gets updated first, and only then the this.eventsGrid.scrollToIndex() gets called.
    • If the this.eventsGrid.scrollToIndex() function is called first, the new pages are not rendered yet
    • I could not make it work with other callback managers, such as InteractionsManager.runAfterInteractions
  • The code got a little messy, if you have any suggestions to improve it let me know!

Add basic usage in README
@pdpino pdpino mentioned this pull request Nov 2, 2020
@hoangnm
Copy link
Owner

hoangnm commented Jan 23, 2021

Hi @pdpino , sorry for the late response. I agree that the code looks a bit messy, but I couldn't find a better suggestion. Let's merge this first and we can improve later. Thanks a lot!

@hoangnm hoangnm merged commit 078164c into hoangnm:master Jan 23, 2021
@pdpino pdpino deleted the bug/go-to-date branch January 27, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't navigate/move to date
2 participants