This repository has been archived by the owner on Mar 27, 2018. It is now read-only.
Constantize: change ';' into constant RS as RootSeparator #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test on a large project by replacing the |
|
Hello :-), We must create 2 constants here: |
| @@ -135,33 +135,35 @@ class Core implements Parameter\Parameterizable { | |||
| */ | |||
| private function __construct ( ) { | |||
|
|
|||
| static::_define('SUCCEED', true); | |||
There was a problem hiding this comment.
The second parameters are right moved (+1 more indentation).
|
ping? |
|
pong! |
|
Please, rebase so that I can merge :-). Sorry for the delay… |
1e1
force-pushed
the
RootSeparator
branch
5 times, most recently
from
21b5bd4
to
c70f7b1
Compare
|
Done. Ready for the code review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RS is choose for RootSeparator and is as long as the DS (Directory) and PS (Path) constants.
It should be more human readable for contributors ;)
REM: Checktyle for the ending space of " * Read from stream"@Protocol.php:763