Late database connection

[guiled]

Open the connection the later we can (not at the Dal construction, but at the first connection need).

It may makes some BC break if user test the connection result on construction.

But I think it is a good practice

• The connection is not opened when a script doesn't need it
• The database resource is less occupied by script using late connection

NB: please consider this PR after #17 as I included the main commit about PHP5.4 migration

[Metalaka]

I like the idea.
But can we use dnew on line 147-148 ?

    $connection = dnew('\Pdo', $this->parameters);

With that we can remove constants and join constructor parameters with func_get_args().

[guiled]

You are absolutely right!

[guiled]

Didn't test it. Can you read it for me please?

[Metalaka]

I've checked out your branch into my Hoa\database tests, they seem work.

[Hywan]

I am assigning @osaris on this PR :-).

[Hywan]

👍 for the idea also!

[osaris]

+1 for the idea, I'll check this PR when #17 is merged for a better readability. Thx.

[Hywan]

PR #17 has been merged. ping then?

[osaris]

ping @guiled can you please rebase your PR ? Thx !

[guiled]

OK @osaris job's done!

[osaris]

Good job, the concept is ok, the code looks good but I ask @Hywan for a code review mainly for Hoa guidelines (indentation, const/var names etc). Thanks.

[osaris]

Please fix alignment.

[Hywan]

First, do not cache the extension_loaded result. It is better to let PHP do that by itself (or in Hoa\Core\Consistency). This is a good idea but it requires a deeper reflection I think.

Second, what do you think to extend this behavior to all the layers? A l'instar of Hoa\Stream with an open and a close methods, we can introduce the open method in Hoa\Database\Dal and update the already existing close method.

Thoughts?

[Hywan]

ping?

[guiled]

I will work on it very soon : this cache will be removed...

[Metalaka]

/ping

[Hywan]

@guiled Ping? Are you available to work on this PR? If no, I guess someone can take over it.

[Hywan]

Any volunteer to work on this PR /cc @hoaproject/hoackers?

[Hywan]

ping?

[Metalaka]

I'll look it this week.

[Hywan]

Perfect, thanks!