-
Notifications
You must be signed in to change notification settings - Fork 6
Generate path for FlexEntity and class_alias #6
Conversation
break; | ||
|
||
case 'd': | ||
$porcelaine = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
porcelain
, not porcelaine
, and it's not that, it's dryRun
. porcelain
is different :-).
@camael24 Could you provide a description and an example of use please? Also, I am not certain to be the one to evaluate this PR. Do you know someone else who could do a peer-review? |
@Hywan thanks to the review, i will apply those modification (not sure "ces modifications") tomorrow, today I too budy The PR its to help the class_alias resolution in destination to our IDE, we juste need to include the generated file in exemple An output exemple file is :
|
@camael24 “these modifications” :-). |
@camael24 I don't use an IDE but does it fit in the IDE's users' workflow? |
I think it can be useful (because I'm very lazy so I need a good auto-completion :). What about adding abstract/interface/trait/final ?
Could be done with ReflexionClass::is*(). |
@Metalaka This PR address a different problem than the (hypothetical) removal PHPDoc. |
ping? |
break; | ||
} | ||
|
||
$hoaPath = 'hoa://Library/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoa will resolve this in the following order and use the first it found.
- Data/Library/Hoathis/
- Data/Library/Hoa/
- vendor/Hoathis/
- vendor/Hoa/
So if Hoa find one of the three first directory the script will not work as expected.
Moreover, it cause problems with Windows :/
I worked on this today: master...Metalaka:alias
@Hywan Should I do a PR on |
@Metalaka Yup, make a PR on this PR. Except if @camael24 is too busy to merge your PR. @camael24: Thoughts? |
Make the PR on my PR i merge it as soon as possible :) |
I juste rebase my PR on master :) and you can go :) |
Done. |
And now? |
Well, sorry but the name is not correct. It's not meaningfull. Any proposal? |
What do you think about |
What about “unfold classnames”? Or better: “unfold entity names”? |
name are too long for the command no ? |
Nop :-p. Maybe “unfold entites” or “resolve entities” can be correct too. |
I can't see how do this in the code causes how manage the space ? with _ ? there are conflict with \ no ? |
@@ -124,7 +124,7 @@ public function main() | |||
|
|||
$arguments[] = $path; | |||
|
|||
$processus = new Console\Processus($phpCsFixer, $arguments); | |||
$processus = new Console\Processus('php '.$phpCsFixer, $arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh?
@camael24 Correct, that's the hoaproject/Core#57 issue. Never mind. Tell me what name you would like to choose and we will see how to format it. |
What is the status of this PR? |
@Hywan @camael24 The feature is waiting for a name. I vote for |
i am agree with |
ping @Hywan see my previous comment |
@camael24 can you go ahead and change the name in the code? |
Resolving implies something that is not solved, so a problem to solve. There is no problem here. What about |
Funny: #6 (comment). |
@Hywan good for me too |
Waiting on @camael24 so 😃. |
@camael24 Have you time to finish this PR or did you want some help ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change the class name
- Increase description
} | ||
|
||
__halt_compiler(); | ||
Resolve class_alias function for the IDE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A much specific description ? something like
Create stub class of flex entities for enable auto completion on IDE
I don't think the word "unfold" is appropriate here. Unfolding means, IMHO, that some things are grouped under a common item (folder containing files for example: when we unfold the directory we see files). Here we only have a single item under a single name: flex entity (alias) => actuel class. I would rather use something like "expand": we go from a short name (flex entity alias) to a full name. Expanding flex entities is done when we generate stubs of flex entity classes: we could have used "generate stubs" but it wouldn't be explicit about which stubs we generate. "expand flex entities" seems ok to me. If you need help here, let me know I should have some time in the coming days. |
👍 for expand. @jubianchi please, feel free to take this PR. I don't have time or energy to take it. |
So let's approve |
👍 |
Closed like it was issued on #43 |
No description provided.