-
Notifications
You must be signed in to change notification settings - Fork 9
Fix double directory separator at the end of root. #4
Conversation
Hello :-), Are we sure that the |
The return value of So if it's not normal, we must close this PR and open another into TestsHoa protocol (local):
Hoa protocol (global):
File system:
|
So, first, are we agree that a trailing slash must be added if this is a directory? This is for security reason. |
ping |
If we say "must be added if this is a directory", so in a first time |
/ping @Hywan At my mind it's better to normalize |
Yes we have to normalize this. So yes, if it is a directory, we have to add a trailing slash. This is why we do in Hoa. What is the next step? |
|
What need to be patched? |
(ahhh, I am lost with all these PR :-p). |
|
Bhoa removed in 9dc6217 ? |
@Metalaka Yup, useless since PHP has its own build-in HTTP server. |
Useless yes, but cool :D |
Sorry, didn't check the conflict with your PR :-(! |
PR for #3.