fix(cli): Remove limit from array length when listing bookmarks. Fixes …

…#135
hoarder-app · May 5, 2024 · 2ed134e · 2ed134e
1 parent 79777bd
commit 2ed134e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/apps/cli/package.json b/apps/cli/package.json
@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@hoarderapp/cli",
-  "version": "0.13.2",
+  "version": "0.13.3",
   "description": "Command Line Interface (CLI) for Hoarder",
   "license": "GNU Affero General Public License version 3",
   "keywords": [

diff --git a/apps/cli/src/commands/bookmarks.ts b/apps/cli/src/commands/bookmarks.ts
@@ -4,6 +4,7 @@ import { Command } from "@commander-js/extra-typings";
 import chalk from "chalk";
 
 import type { ZBookmark } from "@hoarder/shared/types/bookmarks";
+import { MAX_NUM_BOOKMARKS_PER_PAGE } from "@hoarder/shared/types/bookmarks";
 
 export const bookmarkCmd = new Command()
   .name("bookmarks")
@@ -121,10 +122,11 @@ bookmarkCmd
     const request = {
       archived: opts.includeArchived ? undefined : false,
       listId: opts.listId,
+      limit: MAX_NUM_BOOKMARKS_PER_PAGE,
     };
 
-    let results: ZBookmark[] = [];
     let resp = await api.bookmarks.getBookmarks.query(request);
+    let results: ZBookmark[] = resp.bookmarks;
 
     while (resp.nextCursor) {
       resp = await api.bookmarks.getBookmarks.query({
@@ -134,7 +136,7 @@ bookmarkCmd
       results = [...results, ...resp.bookmarks];
     }
 
-    console.log(results.map(normalizeBookmark));
+    console.dir(results.map(normalizeBookmark), { maxArrayLength: null });
   });
 
 bookmarkCmd

diff --git a/packages/shared/types/bookmarks.ts b/packages/shared/types/bookmarks.ts
@@ -89,14 +89,15 @@ export type ZNewBookmarkRequest = z.infer<typeof zNewBookmarkRequestSchema>;
 // GET /v1/bookmarks
 
 export const DEFAULT_NUM_BOOKMARKS_PER_PAGE = 20;
+export const MAX_NUM_BOOKMARKS_PER_PAGE = 100;
 
 export const zGetBookmarksRequestSchema = z.object({
   ids: z.array(z.string()).optional(),
   archived: z.boolean().optional(),
   favourited: z.boolean().optional(),
   tagId: z.string().optional(),
   listId: z.string().optional(),
-  limit: z.number().max(100).optional(),
+  limit: z.number().max(MAX_NUM_BOOKMARKS_PER_PAGE).optional(),
   cursor: z.date().nullish(),
 });
 export type ZGetBookmarksRequest = z.infer<typeof zGetBookmarksRequestSchema>;