Fixes #30. Added toolchain automatic platform detection #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellgithub
reviewed
Dec 14, 2016
There was a problem hiding this comment.
This code gets built on non-emscripten platforms as well, so rather than replace the current checks, it seems better to add them (perhaps EMSCRIPTEN_WINDOWS, EMSCRIPTEN_BSD, etc.) That or you could define the normal system variable that maps to the compiler, though I'm not sure what issues that brings up or why the emscripten compiler doesn't provide them.
|
Yeah I tried adding the system defines; however, they were causing other breaks in emscripten. So, I think I'll need to add EMSCRIPTEN_* defines for this to work correctly sounds like. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues with detecting the endian helpers.