fix warning on bitwise operator with boolean operands #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang 14 -Werror throws warning cpp/lazperf/detail/field_rgb14.cpp:58:11: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
t0b3
added a commit
to t0b3/QGIS
that referenced
this pull request
Apr 4, 2022
error with clang 14
external/lazperf/detail/field_rgb14.cpp:58:11
error: use of bitwise '|' with boolean operands
[-Werror,-Wbitwise-instead-of-logical]
((flag_diff(b.r, b.g, 0x00FF) |
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
||
see also upstream hobuinc/laz-perf#132
t0b3
added a commit
to t0b3/QGIS
that referenced
this pull request
Apr 7, 2022
error with clang 14
external/lazperf/detail/field_rgb14.cpp:58:11
error: use of bitwise '|' with boolean operands
[-Werror,-Wbitwise-instead-of-logical]
((flag_diff(b.r, b.g, 0x00FF) |
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
||
see also upstream hobuinc/laz-perf#132
nyalldawson
pushed a commit
to qgis/QGIS
that referenced
this pull request
Apr 8, 2022
error with clang 14
external/lazperf/detail/field_rgb14.cpp:58:11
error: use of bitwise '|' with boolean operands
[-Werror,-Wbitwise-instead-of-logical]
((flag_diff(b.r, b.g, 0x00FF) |
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
||
see also upstream hobuinc/laz-perf#132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang 14 -Werror throws warning
more details see https://cdash.orfeo-toolbox.org/viewBuildError.php?buildid=95486
reason is operator
|expects bitwise operand but gets boolean operand as per function definitionflag_diffreturnsboolhttps://github.com/hobu/laz-perf/blob/faede41102a65b8c83b21edbd120a000316611da/cpp/lazperf/detail/field_rgb14.cpp#L46
issue was detected downstream in qgis with ci pipeline on fedora 36 using clang 14
while working on qgis/QGIS#47887