Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chihuahua based on ATOM #59

Closed
wants to merge 1 commit into from

Conversation

tombeynon
Copy link

Firstly want to say I love stake.tax and can't wait for it to support more Tendermint chains! Thank you for all your awesome work so far.

The recent proposal to support Chihuahua raised some questions about the work involved due to stake.tax already supporting a few Tendermint/Cosmos chains. It's not always super clear but all tendermint chains share a common API, and while they might implement some more complex functionality like Osmosis and Terra do, for the most part all the basic functions can be handled exactly the same.

I decided to see how much work it would involve to support Chihuahua purely based on one of the existing implementations. I initially cloned Osmosis and just removed the LP functionality, but quickly realised the TX import was split across two different APIs, one of which I didn't recognise.

I then decided to clone Atom which worked very nicely. I removed the legacy functionality for comoshub-3 and Mintscan API, and configured it to use the official chihuahua.wtf API. This works fine in my testing, but longer term it would be good to standardise Tendermint chains so new ones can be added with less duplication.

I also added a docker-compose file and a bit of Readme about that, just because it makes setup easier. If you'd prefer I can remove this from this PR and submit separately.

I appreciate this might not be the perfect solution, but it does support Chihuahua without too much effort. I'd be interested in contributing more to help standardise tendermint moving forward. We could also get it hosted on Akash if you'd be interested.

Additional docker-compose setup and readme
@ericjohncarlson
Copy link

This is awesome! Thank you @tombeynon !

@hodgerpodger
Copy link
Owner

hodgerpodger commented Feb 14, 2022

Thanks. There's some issues as to be expected with a quick start. I'm probably just restart it later since it's probably easier to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants