-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish reorganization #9
Conversation
I agree. I changed my mind last night too.
Agreed. The only reason I didn't do it last night is because I wanted to figure out what to name the |
I'm totally going for the |
👍 |
Also I'm going to remove most of the "Credits" section; |
Can I remove the preambles on |
Please do. |
Can you also update the
Or I can do it later tonight. |
I will do it. |
Done, only two tasks left. |
I did it! I managed to refactor every enum! |
Excellent! I plan to benchmark the branch prediction Houdini added later today and see if it's worth it. |
Goodie! 😃 |
One thing I'd also like to do is to reformat the code Currently there's a mix of tabs, 8 spaces and 4 spaces, |
@jmendeth There's only a few places where spaces are used (I did a Rationale: While I hate tab indentation (seriously, who still uses tabs?) and love me some two space indentation, we would clobber all |
Uhm, yeah, I understand you. |
But if you don't want, that's fine, it's not a must-have for me. I have to go to the bed (or my parents'll kill me) |
Well, thankfully the name changing would only affect lines that used an exposed interface. I'm more concerned with blocks like this: if (i < lang->size) {
size_t org = i;
while (i < lang->size && !isspace(lang->data[i]))
i++;
if (lang->data[org] == '.')
org++; ...which hasn't been clobbered yet, and if it came from a backport we have a clear history on it since I took the time to keep it. We can and should discuss coding style though, but definitely in another issue. |
No, I definitively don't want to spend time debating this aspect. ;) |
Is this ready? |
All ready! It includes your latest changes |
Weeeee! |
Now that @devinus has done the base work,
there's still some things to do, namely:
Code (3)
MKD_
orHTML_
.Building and versioning (4)
html/
directory from Makefiles.Makefile.win
should be modified as well.hoedown.def
.Readme and licensing (5)
README
.all those bindings currently aren't Hoedown bindings.
is not true anymore.
README
's License match withLICENSE
?