Fixed Heap out of bound read in mysofa2json #78

hoene · Sep 7, 2019 · af9bbed · af9bbed
1 parent 90e7bfd
commit af9bbed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/hdf/fractalhead.c b/src/hdf/fractalhead.c
@@ -83,7 +83,7 @@ static int directblockRead(struct READER *reader, struct DATAOBJECT *dataobject,
 		typeandversion = (uint8_t) fgetc(reader->fhd);
 		offset = readValue(reader, offset_size);
 		length = readValue(reader, length_size);
-		if (offset > 0x10000000 || length > 0x10000000)
+		if (offset > 0x10000000 || length > 0x10000000 || length == 0)
 			return MYSOFA_UNSUPPORTED_FORMAT;
 
 		log(" %d %4" PRIX64 " %" PRIX64 "%08lX\n",typeandversion,offset,length,ftell(reader->fhd));