Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.2: no header files installed?馃 #210

Closed
wuch-g2v opened this issue Oct 15, 2023 · 5 comments 路 Fixed by #214
Closed

1.3.2: no header files installed?馃 #210

wuch-g2v opened this issue Oct 15, 2023 · 5 comments 路 Fixed by #214

Comments

@wuch-g2v
Copy link

Looks like in just released 1.3.2 install target do not install any header files:

+ cd libmysofa-1.3.2
+ DESTDIR=/home/tkloczko/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64
+ /usr/bin/cmake --install x86_64-redhat-linux-gnu
-- Install configuration: "RelWithDebInfo"
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/share/libmysofa/default.sofa
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/share/libmysofa/MIT_KEMAR_normal_pinna.sofa
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/pkgconfig/libmysofa.pc
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/cmake/mysofa/mysofaTargets.cmake
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/cmake/mysofa/mysofaTargets-relwithdebinfo.cmake
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/cmake/mysofa/mysofaConfig.cmake
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/cmake/mysofa/mysofaConfigVersion.cmake
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/libmysofa.so.1.3.2
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/libmysofa.so.1
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/lib64/libmysofa.so
-- Installing: /home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/bin/mysofa2json
-- Set runtime path of "/home/builder/rpmbuild/BUILDROOT/libmysofa-1.3.2-2.fc35.x86_64/usr/bin/mysofa2json" to ""
@wuch-g2v
Copy link
Author

cmake -L output:

-- Cache values
ADDRESS_SANITIZE:BOOL=OFF
BUILD_SHARED_LIBS:BOOL=ON
BUILD_STATIC_LIBS:BOOL=OFF
BUILD_TESTS:BOOL=ON
CMAKE_BUILD_TYPE:STRING=RelWithDebInfo
CMAKE_INSTALL_PREFIX:PATH=/usr
CODE_COVERAGE:BOOL=OFF
MATH:FILEPATH=/usr/lib64/libm.so

@hoene
Copy link
Owner

hoene commented Oct 15, 2023

Do you know how to fix it?

@wuch-g2v
Copy link
Author

I've not been looking on that case yet.
I've only noticed that automated rpm package build of updated version libmysofa failed because of missing header files.

@hoene
Copy link
Owner

hoene commented Oct 15, 2023 •
edited
Loading

@andreasfranck May you have a look on this issue because it was introduce by your changes? Includes are only exported if compile with the static option.

@wuch-g2v
Copy link
Author

Includes are only exported if compile with the static option.

Which does not make any sense ..

BSDKaffee added a commit to BSDKaffee/libmysofa that referenced this issue Oct 17, 2023
@BSDKaffee
Install header when only building shared library
1b7d3bb 
Fixes hoene#210
@BSDKaffee BSDKaffee mentioned this issue Oct 17, 2023
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Oct 24, 2023
@bmwiedemann
Update libmysofa to version 1.3.2 / rev 13 via SR 1119467
7a5b32c 
https://build.opensuse.org/request/show/1119467
by user mia + anag+factory
- Update to 1.3.2:
  * allow slightly more dense HRTFs
  * allow all kinds of room types
  * target exporting
  * bug fix in memory reader
  * enable big endian support
- Drop 0001-fix-big-endian-convertion-of-double-value.patch
- Add Install-header-when-only-building-shared-lib.patch
  See hoene/libmysofa#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install header when only building shared library BSDKaffee/libmysofa
2 participants
@hoene @wuch-g2v