Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twitter Card defaults and fallback #12

Merged
merged 2 commits into from Mar 16, 2021

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Feb 1, 2021

This PR fixes the erroneous defaults for hofff_st_twitter_type in the DCA - and the fallback for hofff_st_twitter_type in the TwitterCardsFactory.

@fritzmg fritzmg changed the title Fix twitter card defaults and fallback Fix Twitter Card defaults and fallback Feb 1, 2021
@fritzmg
Copy link
Contributor Author

fritzmg commented Feb 1, 2021

Note: the following SQL queries might be necessary afterwards, in order to fix the wrong default values in the database:

UPDATE tl_news SET hofff_st_twitter_type = '' WHERE hofff_st_twitter_type = 'website';
UPDATE tl_page SET hofff_st_twitter_type = '' WHERE hofff_st_twitter_type = 'website';
UPDATE tl_faq SET hofff_st_twitter_type = '' WHERE hofff_st_twitter_type = 'website';
UPDATE tl_calendar_events SET hofff_st_twitter_type = '' WHERE hofff_st_twitter_type = 'website';

@dmolineus
Copy link
Collaborator

Thanks @fritzmg

@dmolineus dmolineus changed the base branch from master to develop March 16, 2021 10:47
@dmolineus dmolineus merged commit 30dbecd into hofff:develop Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants