New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Twitter Cards when no Twitter username is present #13

Merged

dmolineus merged 1 commit into hofff:develop from fritzmg:fix-twitter-card

Mar 16, 2021

Contributor

fritzmg commented Feb 1, 2021

The twitter:site property is optional for Twitter Cards (see https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image - only twitter:card and twitter:title are mandatory). However the current implementation basically omits all properties (except twitter:card) if no site information is present (i.e. the Twitter username).

This PR removes the check for the site for the affected properties.


          fix twitter cards

c8817c7

dmolineus changed the base branch from master to develop

March 16, 2021 10:47

dmolineus merged commit c05fbda into hofff:develop

Collaborator

dmolineus commented Mar 16, 2021

Thanks @fritzmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment