Skip to content

Commit

Permalink
Autobuild: Ensure JACK install completion
Browse files Browse the repository at this point in the history
Previously, the JACK installers were started as ordinary programs. As
they are GUI applications, they detach from the console and the
powershell build script (and Github Actions) continues.
Therefore, once the actual build starts, the JACK installation may not
have finished at all.
This commit uses Powershell's Start-Process -Wait feature to wait
for completion before continuing.

Fixes: jamulussoftware#3035
  • Loading branch information
hoffie committed Dec 9, 2023
1 parent 3cc4318 commit aeb7239
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/autobuild/windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ Function Ensure-JACK

$JACKInstallPath = "${DownloadCacheDir}\JACK64.exe"

& $JACKInstallPath $JACKInstallParms
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"

if ( !$? )
{
Expand All @@ -198,7 +198,7 @@ Function Ensure-JACK

$JACKInstallPath = "${DownloadCacheDir}\JACK32.exe"

& $JACKInstallPath $JACKInstallParms
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"

if ( !$? )
{
Expand Down

0 comments on commit aeb7239

Please sign in to comment.