fix: fixed exit callback not having access to dpg commands #1448 (#1458)

hoffstadt · Nov 29, 2021 · 69aeb79 · 69aeb79
1 parent aa936d9
commit 69aeb79
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/DearPyGui/src/core/mvCallbackRegistry.cpp b/DearPyGui/src/core/mvCallbackRegistry.cpp
@@ -95,7 +95,6 @@ namespace Marvel {
 			GContext->callbackRegistry->callCount--;
 		}
 
-		mvRunCallback(GContext->callbackRegistry->onCloseCallback, 0, nullptr, nullptr);
 		return true;
 	}
 

diff --git a/DearPyGui/src/core/mvContext.cpp b/DearPyGui/src/core/mvContext.cpp
@@ -121,6 +121,16 @@ namespace Marvel {
             return;
         }
 
+        // hacky fix, started was set to false
+        // to exit the event loop, but needs to be
+        // true in order to run DPG commands for the 
+        // exit callback.
+        GContext->started = true;
+        mvSubmitCallback([=]() {
+            mvRunCallback(GContext->callbackRegistry->onCloseCallback, 0, nullptr, nullptr);
+            GContext->started = false;  // return to false after
+            });
+
         imnodes::DestroyContext();
         ImPlot::DestroyContext();
         ImGui::DestroyContext();