Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod docs n tests #71

Merged
merged 32 commits into from Sep 19, 2021
Merged

Mod docs n tests #71

merged 32 commits into from Sep 19, 2021

Conversation

verdverm
Copy link
Member

@verdverm verdverm commented Aug 8, 2021 •
edited

Changes:

  1. Rewrite some of the auth logic, trying to add auth to requests when available, regardless of private repo or not. This is desirable so that API limits are greater (for example we have seen CI errors from hitting the API rate limiting with public only deps)
  2. Enable private module tests in CI

TODO:

  • more private module tests
    • authentication methods
    • gitlab
    • plain git
  • Documentation
    • CLI docs
    • website docs
  • can we lookup auth per provider once and store in mem for reuse as we process the dep graph?

@verdverm
move mod cred helpers to yagu for more general usage
fe4fbb8 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
push mod fetch details into remote types
f202e6a 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix private github zip fetching and add test
a3678d6 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
enable github auth for testing mods
06eca95 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
remove some print statements
d545a85 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fixup some api tests, enable expected failures, run api tests in work…
d3a29ef 
…flow

Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
use custom secret for hofmod
821818d 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix var interpolation in workflow
072d279 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@b4nst b4nst mentioned this pull request Aug 18, 2021
Closed
@verdverm
start breaking out more GHA workflows
94567c1 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
flatten for test_mod to work(flow)
dd9bc15 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm verdverm mentioned this pull request Aug 24, 2021
Closed
@verdverm
uncomment the actaul test...
42f97fc 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
add fail case when auth not present
fb90b70 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
update some repo deps, cleanup a bit of logic, make notes about auth …
aa0ce81 
…impl

Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
add private gitlab mod test
8e7a1b5 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
add GITLAB_TOKEN to vars passed during mod test, make easier to expand
5d48525 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
breakout windows into own workflow; switch trigger to push
3701fe4 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix windows workflow cue
0ef11eb 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
change test_mod trigger to push
4510aa5 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
try seeing if path matching works on full PR changeset
f94e45a 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
remove windows workflows, too many issues with GHA and the code base;…
77e454e 
… windows is not officially supported at this point

Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
add lookup for default pub key when ssh config not found; start tests…
1f59219 
… for sshkey based auth flows

Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix some errors
a894c2c 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
Copy link
Member Author

verdverm commented Sep 1, 2021

Found some unexpected behavior in the ssh_config module

kevinburke/ssh_config#34

@verdverm
push code with ssh_config issue
b6b20da 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
add bitbucket support
01ec0ec 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
create GHA env for mod testing, update secrets
a05413f 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
work on sshkey auth test
4a6707b 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
empty more vars in sshkey test
132b89d 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix bbc auth vars used in testing; remove a bunch of debug prints
75dff8e 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
fix var name with sshkey auth
ae5e877 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
update mod docs
a6ba252 
Signed-off-by: Tony Worm <tony@hofstadter.io>
@verdverm
Copy link
Member Author

Merging despite failing CI tests. Verified the auth methods work locally.

@verdverm verdverm merged commit ac766d2 into _dev Sep 19, 2021
@verdverm verdverm mentioned this pull request Sep 19, 2021
Closed
@verdverm verdverm deleted the mod-docs-n-tests branch December 28, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@verdverm