Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working towards fixing mvn install compile errors for Java 8 #37

Closed
wants to merge 3 commits into from

Conversation

daveyarwood
Copy link
Collaborator

See discussion in #31. I thought I would submit a PR for the fixes I've done so far, working towards getting mvn install to work on the develop branch. I'm using Java 8.

This PR includes the java8 branch, which fixes the "Unable to get XClass for ..." errors.

findbugs still found one bug which causes mvn install to fail:

[INFO] --- findbugs-maven-plugin:3.0.5:check (default) @ javaosc-core ---
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Class com.illposed.osc.OSCMessageEvent defines non-transient non-serializable instance field message [com.illposed.osc.OSCMessageEvent] In OSCMessageEvent.java SE_BAD_FIELD

I'm punting on fixing that on this branch. On the up side, I am able to get mvn install to succeed if I temporarily remove the fixbugs plugin from the pom.xml, so it isn't really blocking me at this point.

@hoijui
Copy link
Owner

hoijui commented Feb 18, 2019

included in branch develop as of now. thanks! :-)

@hoijui hoijui closed this Feb 18, 2019
@daveyarwood daveyarwood deleted the java8-fixes branch February 18, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants