Skip to content

Commit

Permalink
Actionbar Dashboard: set title visibility to "invisible" so the icons…
Browse files Browse the repository at this point in the history
… appear right-justified.
  • Loading branch information
hoisie committed Nov 4, 2010
1 parent d1d30be commit 3e18f9a
Showing 1 changed file with 17 additions and 15 deletions.
32 changes: 17 additions & 15 deletions GreenDroid/res/layout/gd_action_bar_dashboard.xml
Expand Up @@ -31,21 +31,23 @@

<!--
The following TextView could contain the title of the current screen.
Actually, I don't think having a title in the ActionBar of type
Dashboard is a good idea so I prefer removing it.
Its visibility is set to "invisible" because having a title in a dashboard
doesn't make sense. However, if it is removed, the dashboard icons aren't
right-aligned.
-->
<!-- <TextView-->
<!-- style="?attr/gdActionBarTitleStyle"-->
<!-- android:id="@+id/gd_action_bar_title"-->
<!-- android:layout_width="0dp"-->
<!-- android:layout_height="fill_parent"-->
<!-- android:layout_weight="1.0"-->
<!-- android:gravity="left|center_vertical"-->
<!-- android:singleLine="true"-->
<!-- android:textColor="?attr/gdActionBarTitleColor"-->
<!-- android:textSize="16sp"-->
<!-- android:textStyle="bold"-->
<!-- android:paddingRight="10dp"-->
<!-- android:paddingLeft="10dp" />-->
<TextView

This comment has been minimized.

Copy link
@cyrilmottier

cyrilmottier Nov 4, 2010

Why using a TextView ? I think just using an invisible View would be better (more simple and clearer). This View is simply used as a spacer between the application drawable and the items.

This comment has been minimized.

Copy link
@hoisie

hoisie Nov 4, 2010

Author Owner

Thanks, I pushed a new commit which replaces the TextView with a View.

style="?attr/gdActionBarTitleStyle"
android:id="@+id/gd_action_bar_title"
android:layout_width="0dp"
android:layout_height="fill_parent"
android:layout_weight="1.0"
android:gravity="left|center_vertical"
android:singleLine="true"
android:textColor="?attr/gdActionBarTitleColor"
android:textSize="16sp"
android:textStyle="bold"
android:paddingRight="10dp"
android:paddingLeft="10dp"
android:visibility="invisible" />

</merge>

0 comments on commit 3e18f9a

Please sign in to comment.