support for multiple static directories with failover #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2016 12:16
…und. added support for multiple custom defined static directories, both in the existing string format (so as not to be breaking to existing uses) and through a new string array that caches the list
|
realised I forgot to push the fixed version, pardon me. Ill correct that |
|
forgot to call gofmt, apologies, it appears to be a forgetful day today. |
|
Out of curiosity, could you achieve the same thing using symbolic links in the filesystem? |
|
most likely, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing static directories string is now tokenized and caches in a slice and serving static files iterates over this slice to find the directory.
If it is unable to find the file if fails over the the default static directories rather than failing outright (old behavior).
This is useful when trying to serve vendor files from a package manager (i.e. npm) as I didnt wish to move my static files into "node_modules"