Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate relations ID #21

Closed
speed-of-heat opened this issue May 4, 2021 · 10 comments
Closed

Duplicate relations ID #21

speed-of-heat opened this issue May 4, 2021 · 10 comments

Comments

@speed-of-heat
Copy link

Joypro
Any idea how to get rid of the duplicate names ?

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

Mhh i mean the titles are duplicates but the hashes are not, So it might be a different function inside DCS

@speed-of-heat
Copy link
Author

speed-of-heat commented May 5, 2021

My original problem was that a button mapping, wasn't showing up at all (for these ID's the rest worked fine), I was pulling my hair out, but when i looked in the diff.lua, I found the buttons were present, but, when I imported the binding back into Joypro from DCS they would disappear in joypro.

I then exported the DCS mappings to HTML to compare them and found that the same function STORES SELECT n and PCA SELECT n, both had different ID's in the Joypro DB.

The "correct" ID's are the shorter ones, that one comes from the export to HTML from the mirage, the longer one seems to be from the joypro database file for the mirage 2000, the shorter ID's are recognised by DCS.

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

Ah interesting, so the IDs have changed or my Mirage have different hashIDs other than yours. Thats weird but if the latter is the case idk what to do about it, as both is needed depending on the mirage installation

@speed-of-heat
Copy link
Author

right, so the question is this isolated or can it happen elsewhere....

if it does happen else where we need a way of editing out the old ones from the DB/overriding them. The problem here is of course we end up with a bunch of variations that need to be saved and maintained and updated etc...

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

Thing is, if it happens that the ID changed due to an update, how can JP know it did?

For updating or adding new IDs to the database that's less of an issue i thought of building in a feature if it doesn't know the ID that it adds it to the DB, if there is something in the saved profile, or in the imported diff lua or in the html files.

But the other way around might be problematic to detect.

@speed-of-heat
Copy link
Author

yeah , thats why i think it needs to be a human driven UI if you accommodate it at all...

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

yeah but how would that look like? If i push a new version, i always push the build of my database, so if manually edit something in yours, the changes would get overwritten as soon as a new version drops.
If i change that so you would maintain your first download Database, then for instance if i include like the Mi-24 in the next update, you wouldn't get it until you generated an HTML on your end.

The only somewhat viable thing in that regards if you do manual changes to the DB, that is changes them as a difference and when you use the next version that it can look up the differences you have previously made.

@speed-of-heat
Copy link
Author

I was think more of a separate diff db for each user that they are responsible for maintaining

if aircraft + description has more than one ID throw UI , Keep, Choose -> write to local diff db

have a menu option to revert one or more changes, if it no longer works, or force behaviour

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

I will add it to my feature request list

@Holdi601
Copy link
Owner

Holdi601 commented May 5, 2021

I have added my todo list to the front readme file , so people can see what is on the list.

@Holdi601 Holdi601 closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants