Move integration test with external dependencies to test/end-to-end (#…

…180) * Skip flaky relay test * Add info * Don't run end-to-end tests on the CI
holepunchto · Apr 25, 2024 · ad11e77 · ad11e77
1 parent a9cef54
commit ad11e77
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -52,7 +52,8 @@
     "test": "standard && node test/all.js",
     "test:generate": "brittle -r test/all.js test/*.js",
     "lint": "standard",
-    "integration": "brittle test/integration/*.js"
+    "integration": "brittle test/integration/*.js",
+    "end-to-end": "brittle test/end-to-end/*.js"
   },
   "author": "Mathias Buus (@mafintosh)",
   "license": "MIT",

diff --git a/...egration/fixtures/server-through-relay.js → ...d-to-end/fixtures/server-through-relay.js b/...egration/fixtures/server-through-relay.js → ...d-to-end/fixtures/server-through-relay.js
diff --git a/test/end-to-end/info.txt b/test/end-to-end/info.txt
@@ -0,0 +1,6 @@
+The tests in this directory are not self-contained.
+Since they depend on outside services (like the prod DHT) they can be flaky.
+This means that a single failure of an end-to-end test is no cause for alarm.
+However, repeated failures when the service depended upon is available is a red flag.
+
+Because of their flakiness, they should not be added to automated runs (like the CI)
diff --git a/test/integration/keep-alive-with-relay.js → test/end-to-end/keep-alive-with-relay.js b/test/integration/keep-alive-with-relay.js → test/end-to-end/keep-alive-with-relay.js