Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO's before marking ready: (all done)
Should the keepAlives for the relays use the passed-in value if non-0, or remain fixed at 5s? (
hs.relaySocket.setKeepAlive(5000)
and
c.relaySocket.setKeepAlive(5000)
)can be considered laterhyperdht/lib/server.js
Line 613 in 79eea93
hyperdht/lib/connect.js
Line 693 in 79eea93
Cut a hyperswarm-secret-stream release with Expose keepAliveMs hyperswarm-secret-stream#30 so the tests don't rely on a private propDone