add tests for downloading empty file/dir to fs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 nice |
| var drive = hyperdrive(memdb()) | ||
| var driveClone = hyperdrive(memdb()) | ||
| var tmp = path.join(os.tmpdir(), 'hyperdrive-test') | ||
| mkdirp.sync(tmp) |
There was a problem hiding this comment.
we don't need mkdirp for that, os.tmpdir should already exist
|
after the comments, +1, great work! |
joehand
force-pushed
the
add-empty-fs-test
branch
2 times, most recently
from
5ecb112
to
84b86e2
Compare
|
Thanks @juliangruber, updated with your comments. |
|
+1! |
|
Do we want to make this as todo test and merge? It seems we need to either have raf or additional storage api to support mkdir. |
|
well marking as todo requires tape-testing/tape#254 |
|
@clkao use tape.skip and add a todo comment for now. mkdir will be a hyperdrive option where you can pass a mkdir handler in hyperdrive |
joehand
force-pushed
the
add-empty-fs-test
branch
from
84b86e2
to
cb28891
Compare
|
@mafintosh changed the tests to skip. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds (currently failing) tests for downloading empty file/directory to file system. #28