New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make updateNotify sync #68

Merged

davidmarkclements merged 1 commit into main from sync-updateNotify

Mar 4, 2024

Contributor

HDegroote commented Mar 4, 2024

The rest of the code already assumes updateNotify is sync, so making it async was most likely an accident

(looping over this.clients is sync, so it should not have been an async iterator)


          Make updateNotify sync

dd59818

HDegroote mentioned this pull request

(WIP) Treat updateNotify async #67

Closed

davidmarkclements merged commit b7bae31 into main

2 checks passed

davidmarkclements deleted the sync-updateNotify branch

March 4, 2024 11:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment