Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio util improvements #57

Merged
merged 2 commits into from
Apr 20, 2024
Merged

asyncio util improvements #57

merged 2 commits into from
Apr 20, 2024

Conversation

holesch
Copy link
Owner

@holesch holesch commented Apr 20, 2024

  • util: Don't Raise Exceptions in cancel_tasks()
  • util: Cancel task if background task fails

@holesch
util: Don't Raise Exceptions in cancel_tasks()
fc37583 
First wait for all tasks to finish and then only log exceptions, since
the caller is not interested in the result of the tasks.
@holesch
util: Cancel task if background task fails
ee4ce4a 
Cancel the foreground task as soon as the background task fails and
raise the exception of the background task. With that, background task
failures can be noticed immediately, not only after stopping the
process.
@holesch holesch merged commit ee4ce4a into master Apr 20, 2024
9 checks passed
@holesch holesch deleted the asyncio-util-improvements branch April 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@holesch