Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-F needed in ws_release even WS is in default File System #49

Open
mflehmig opened this issue Apr 27, 2020 · 4 comments
Open

-F needed in ws_release even WS is in default File System #49

mflehmig opened this issue Apr 27, 2020 · 4 comments

Comments

@mflehmig
Copy link
Contributor

Hello Holger,

as far as I can see, the option -F FS is mandatory for ws_release even for workspaces in the default file system. This is inconsistent behavior w.r.t. the other ws-commands, where the default FS is used if the option -F is not provided by the users.

Can this be fixed?

Best regards
Martin

@holgerBerger
Copy link
Owner

I think the idea behind that is to avoid releasing the wrong one in case the name exists in several FS.
I can have a look how complex it is to require -F only if the name is not unique.

@mflehmig
Copy link
Contributor Author

I think the idea behind that is to avoid releasing the wrong one in case the name exists in several FS.
Good point. Then, it should be explicitly documented. Furterhmore, ws_allocate -x might print an appropriate error/warning(?) and not "Error: workspace does not exist, can not be extended!".

@holgerBerger
Copy link
Owner

I think the idea behind that is to avoid releasing the wrong one in case the name exists in several FS.
I can have a look how complex it is to require -F only if the name is not unique.

@holgerBerger
Copy link
Owner

holgerBerger commented Apr 28, 2020

I checked it, one does not need to give -F when the workspace is in default, only if it not in default.

I added debugging option (which was already in the code) to ws_release, and one can see the search process when giving --debug.

It searches if no -F is given (that happens in validation of command line) trough the workspaces, and if nothing is found it uses the default.

debug: no filesystem given, searching...
debug: searching ws1
debug: searching ws10
debug: searching ws2
debug: searching ws3
debug: fallback, using global default, ending search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants