Skip to content

Commit

Permalink
Release commit for v.0.4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
holgerd77 authored and holgerd77 committed Jun 4, 2015
1 parent ec3aa51 commit f6c3dee
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
15 changes: 11 additions & 4 deletions docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ or on a per-test-case level like this::

Have a look at the ``run_tests.sh`` shell script for more examples!

.. _releasenotes:
.. _scraper_js_tests:

Running ScrapyJS/Splash JS rendering tests
------------------------------------------
Expand All @@ -90,11 +90,18 @@ Docker container can be run with::
For rendering websites served on ``localhost`` from within ``Docker/Splash``, you can connect to ``localhost`` outside the ``Docker container`` via ``http://10.0.2.2``
(see e.g. `Stackoverflow <http://stackoverflow.com/questions/1261975/addressing-localhost-from-a-virtualbox-virtual-machine>`_).

.. _releasenotes:

Release Notes
=============
**Changes in version 0.4.1-beta** (Not yet released)

* TODO
**Changes in version 0.4.1-beta** (2015-06-04)

* Support for ``Javascript`` rendering of scraped pages via ``ScrapyJS/Splash``
* Feature is optional and needs a working ScrapyJS/Splash deployment, see :ref:`requirements` and
:ref:`setting_up_scrapyjs_splash`
* New attribute ``render_javascript`` for ``Scraper`` model, run ``python manage.py migrate dynamic_scraper`` to
apply (migration ``0002``)
* New unit tests for Javascript rendering (see: :ref:`scraper_js_tests`)

**Changes in version 0.4.0-beta** (2015-06-02)

Expand Down
2 changes: 2 additions & 0 deletions docs/getting_started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ from this example is used in the following guidelines.
Installation
============

.. _requirements:

Requirements
------------
The **basic requirements** for Django Dynamic Scraper are:
Expand Down
2 changes: 1 addition & 1 deletion dynamic_scraper/spiders/django_base_spider.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def __init__(self, *args, **kwargs):
def start_requests(self):
for url in self.start_urls:
meta = {}
if self.scraper.render_javascript:
if hasattr(self, 'scraper') and self.scraper.render_javascript:
meta['splash'] = {
'endpoint': 'render.html',
'args': {'wait': 0.5}
Expand Down

0 comments on commit f6c3dee

Please sign in to comment.