Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discussions_by_author_before_date in get_discussions #95

Merged
merged 3 commits into from Oct 6, 2018
Merged

Fix Discussions_by_author_before_date in get_discussions #95

merged 3 commits into from Oct 6, 2018

Conversation

espoem
Copy link
Contributor

@espoem espoem commented Oct 6, 2018

Fixes #93

  • adds author, before_date params to Query class
  • fixes input params
  • updates docstring

holgern
holgern approved these changes Oct 6, 2018
View reviewed changes
Copy link
Owner

@holgern holgern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, It looks good to me.

@holgern holgern merged commit 2d8af1e into holgern:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgern holgern holgern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong input parameters for Discussions_by_author_before_date in Docstring and get_discussions
2 participants
@espoem @holgern