Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a system-wide edflib (fix #149) #150

Closed
wants to merge 1 commit into from

Conversation

musicinmybrain
Copy link
Contributor

Adds an environment variable SYSTEM_EDFLIB. When it is set empty or to 1, the bundled EDFlib sources are not compiled, and a system-wide edf library is linked instead.

Adds an environment variable SYSTEM_EDFLIB. When it is set empty or to
“1”, the bundled edflib sources are not compiled, and a system-wide
“edf” library is linked instead.
@skjerns
Copy link
Collaborator

skjerns commented Nov 20, 2021

Thanks for the PR, that looks interesting indeed. I'll have a look at it the coming days. As it is purely additional and does not infer with the commonly used install mode, it should be fine to merge.

@musicinmybrain
Copy link
Contributor Author

I see now that the bundled EDFlib is actually a fork, with at least some added error codes and an extra size-check parameter to edfopen_file_readonly. As long as pyedflib needs to fork EDFlib, this PR isn’t actually useful.

@skjerns
Copy link
Collaborator

skjerns commented Nov 20, 2021

I see now that the bundled EDFlib is actually a fork, with at least some added error codes and an extra size-check parameter to edfopen_file_readonly. As long as pyedflib needs to fork EDFlib, this PR isn’t actually useful.

Yes, that is true. However, we could think about making some of the changes optional, I don't think all of them are extremely important. On the other side, it should be no problem to recompile the source for installing the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants