Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEP 0.1 #2

Merged
merged 35 commits into from
Nov 19, 2018
Merged

Conversation

YoungFaithful
Copy link
Collaborator

No description provided.

@holgerteichgraeber
Copy link
Owner

Please add me as reviewer next time so that I get notified upon submission. Thanks

@YoungFaithful YoungFaithful removed the request for review from holgerteichgraeber November 15, 2018 23:45
data/CEP/GER/nodes.csv Outdated Show resolved Hide resolved
data/CEP/GER/techs.csv Outdated Show resolved Hide resolved
data/CEP/GER/fixprices.csv Outdated Show resolved Hide resolved
data/CEP/GER/varprices.csv Outdated Show resolved Hide resolved
examples/workflow_example.jl Outdated Show resolved Hide resolved
src/utils/datastructs.jl Outdated Show resolved Hide resolved
src/utils/datastructs.jl Outdated Show resolved Hide resolved
src/utils/load_data.jl Outdated Show resolved Hide resolved
src/utils/load_data.jl Outdated Show resolved Hide resolved
src/utils/utils.jl Outdated Show resolved Hide resolved
@holgerteichgraeber
Copy link
Owner

Concerning all the csv files, we should define units somewhere. This includes CO2, and fixed and variable costs, and installed capacity. Where do you think is best to do that?

@YoungFaithful
Copy link
Collaborator Author

Concerning all the csv files, we should define units somewhere. This includes CO2, and fixed and variable costs, and installed capacity. Where do you think is best to do that?

I think we should include that in the load_data function description

Copy link
Owner

@holgerteichgraeber holgerteichgraeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes below

set[:sector]=unique(cepdata.techs[:sector])
#Different set: set[:sector]=unique(cepdata.techs[:sector]) .. CAP[node,tech,sector]
#Or specific variables for each sector ELCAP, HEATCAP
set[:time_k]=1:tsdata.K

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do time_K and time_T

"""
function setup_cep_opt_sets(tsdata::ClustInputData,cepdata::CEPData)
set=Dict{Symbol,Array}()
set[:nodes]=cepdata.nodes[:nodes]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we decide on this one? how about set["nodes"] to have it consistent?

"""
function setup_cep_opt_sets(tsdata::ClustInputData,cepdata::CEPData)
set=Dict{Symbol,Array}()
set[:nodes]=cepdata.nodes[:nodes]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cepdata.nodes[:nodes] should stay this way I assume because it comes from a dataframe

@holgerteichgraeber holgerteichgraeber merged commit 5ffe494 into holgerteichgraeber:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants