-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEP 0.1 #2
CEP 0.1 #2
Conversation
Time Series Loading finished CEP Loading finished Demand Timeseries expanded
CEP - Core
Please add me as reviewer next time so that I get notified upon submission. Thanks |
Co-Authored-By: YoungFaithful <kuepper@stanford.edu>
Co-Authored-By: YoungFaithful <kuepper@stanford.edu>
Concerning all the csv files, we should define units somewhere. This includes CO2, and fixed and variable costs, and installed capacity. Where do you think is best to do that? |
I think we should include that in the load_data function description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes below
src/optim_problems/run_opt.jl
Outdated
set[:sector]=unique(cepdata.techs[:sector]) | ||
#Different set: set[:sector]=unique(cepdata.techs[:sector]) .. CAP[node,tech,sector] | ||
#Or specific variables for each sector ELCAP, HEATCAP | ||
set[:time_k]=1:tsdata.K |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do time_K and time_T
src/optim_problems/run_opt.jl
Outdated
""" | ||
function setup_cep_opt_sets(tsdata::ClustInputData,cepdata::CEPData) | ||
set=Dict{Symbol,Array}() | ||
set[:nodes]=cepdata.nodes[:nodes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we decide on this one? how about set["nodes"] to have it consistent?
src/optim_problems/run_opt.jl
Outdated
""" | ||
function setup_cep_opt_sets(tsdata::ClustInputData,cepdata::CEPData) | ||
set=Dict{Symbol,Array}() | ||
set[:nodes]=cepdata.nodes[:nodes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cepdata.nodes[:nodes] should stay this way I assume because it comes from a dataframe
No description provided.