Saving #22
Merged
Saving #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleted kwargs as deprecated in the other functions
|
I thought it should work like you did, but have a look at the Files Changed tab, it somehow shows all the old changes. Could you close this one and add a new PR? There must be a way to do several PRs parallel, if you come across something, let me know, I'll have a look as well. |
|
Or can you try git pull holger master into the Saving branch? That should do a fast forward merge and we could check if it solved the issue. |
YoungFaithful
commented
Nov 28, 2018
|
I appreciate the comments on some of the changes, thank you! |
holgerteichgraeber
requested changes
Nov 30, 2018
There was a problem hiding this comment.
- What do you think about moving the function attribute_weighting() from run_clust.jl to utils/utils.jl ? I feel that run_clust() should only keep the clustering functions themselves.
- Could you change Line 147 in run_clust() to
results_ar = Array{ClustResult,1}(undef,length(n_clust_ar)), somehow I cannot make that comment in the code review (probably because that part of the file did not change)?
Co-Authored-By: YoungFaithful <kuepper@stanford.edu>
Co-Authored-By: YoungFaithful <kuepper@stanford.edu>
|
Should be done |
YoungFaithful
commented
Nov 30, 2018
holgerteichgraeber
approved these changes
Dec 3, 2018
|
@YoungFaithful : Just pushed a small fix in workflow_example_bat to master, everything should be working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClustResultBest implemented, ClustResultAll as option in run_clust, deleted kwargs as deprecated in the other functions
@holgerteichgraeber Do I need to open that after the other one is approved or will it work as soon as you accepted the other one?