Skip to content

Commit

Permalink
feat: filter out countries without public holidays
Browse files Browse the repository at this point in the history
Fairly minor update, no code change, just added a new test to cover the
flag that was recently added to the API and expanded the documentation
to also include it.
  • Loading branch information
joshtronic committed Mar 4, 2020
1 parent 054eab9 commit 12f1ea6
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 1 deletion.
8 changes: 8 additions & 0 deletions README.md
Expand Up @@ -67,6 +67,14 @@ try {
$holiday_api->countries();
```

#### Fetch only countries with public holidays

```php
$holiday_api->countries([
'public' => true,
]);
```

#### Fetch a supported country by code

```php
Expand Down
2 changes: 1 addition & 1 deletion composer.json
@@ -1,7 +1,7 @@
{
"name": "holidayapi/holidayapi-php",
"description": "Official PHP library for Holiday API",
"version": "2.2.0",
"version": "2.2.1",
"type": "library",
"keywords": [
"calendar",
Expand Down
34 changes: 34 additions & 0 deletions tests/ClientTest.php
Expand Up @@ -165,6 +165,40 @@ public function testReturnCountryByCode()
), $client->countries(array('country' => 'ST')));
}

public function testReturnCountryWithPublic()
{
$url = self::BASE_URL . 'countries?key=' . self::KEY . '&public=1';

$request = new Request(array(
'execute' => array(
$url => function ()
{
return json_encode(array(
'status' => 200,
'countries' => array(
array(
'code' => 'ST',
'name' => 'Sao Tome and Principle',
),
),
));
},
),
));

$client = new Client(array('key' => self::KEY, 'handler' => $request));

$this->assertEquals(array(
'status' => 200,
'countries' => array(
array(
'code' => 'ST',
'name' => 'Sao Tome and Principle',
),
),
), $client->countries(array('public' => true)));
}

public function testCountriesRaise4xxErrors()
{
$url = self::BASE_URL . 'countries?key=' . self::KEY;
Expand Down

0 comments on commit 12f1ea6

Please sign in to comment.