Enabling the Tile Component to utilise the image component #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking IP/Dev |
| @@ -1,6 +1,6 @@ | |||
| var image = { | |||
| src: 'http://brand.holidayextras.com/img/product-main.jpg', | |||
| alt: 'Two course meal' | |||
| alt: 'Tender sirloin steak with blue cheese dressing' | |||
There was a problem hiding this comment.
Should we change <UIToolkit.Tile image={image} title on line 7, to also equal this?
|
Taking SE/Dev |
|
Looks good to me +1 |
|
taking guru |
|
Can we start adding some real tests for these components now? Perhaps one that asserts the imageComponent is rendered and is in the correct place would be a good start? |
|
👍 |
added 2 commits
May 28, 2015 15:28
|
@lukehansell-hx There is a PR to move from JEST to Mocha/Chai so I don't want to write tests here which conflict. More tests will be written once we have moved. |
|
👍 from me... can I ask what the change in test suite is for? I'm not overly fond of Jest, but I do like the stubbing functionality it gives us. |
|
@lukehansell-hx we have moved for a few reasons..
|
added 2 commits
May 29, 2015 10:42
jodiedoubleday
pushed a commit
that referenced
this pull request
May 29, 2015
Enabling the Tile Component to utilise the image component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What unit or integration tests does this PR have?
None
What selenium tests does this PR have?
None
How should a developer review this?
The best way to test this would be to
console.login the image component and make sure the log is shown when running the docsHow should this be manually tested?
npm installgrunt docsCheck that images are displayed on the docs
Any background context you want to provide?
What are the relevant tickets?
UXUI-250
What gif best describes how you feel about this work?
Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):
IP or Developer Review:
Software Engineer or Developer review:
Software Engineer or project guru review: