Creating a quote component #38
Conversation
|
Taking SE. |
|
Taking Dev |
| return ( | ||
| <q className={classNames(classes)} cite={this.props.cite} itemScope itemType="http://schema.org/CreativeWork" itemProp="text"> | ||
| {this.props.children} | ||
| {(this.props.cite) ? <meta itemProp="citation" content="{this.props.cite}" /> : null} |
There was a problem hiding this comment.
should the double quotes be removed here: content="{this.props.cite}"
The output in the html is this as a string: http://grab.by/IDdi
|
Minor comment (for future reference, and the you're most probably aware of) regarding the testing instructions: |
| @@ -0,0 +1,8 @@ | |||
| var example = ( | |||
| <div> | |||
| <p>Gandalf, Captain of the starship enterprise said <UIToolkit.Quote type="inline" author="Gandalf" role="Captain of the Starship Enterprise" cite="The Internet" purpose="success">Use the force Harry</UIToolkit.Quote> | |||
There was a problem hiding this comment.
Enterprise is a proper noun and should be capitalised (disclaimer: I am not a trekkie). Same probably goes for the Force.
There was a problem hiding this comment.
If I move the <UIToolkit.Quote> element to the next line in the docs (i.e. replace the space character before the opening tag with a newline), the white space between the previous text and the element disappears in the rendered result. It appears to be the case that any amount of white space other than a single space character results in the white space being removed from the rendered result. Is this a bug?
There was a problem hiding this comment.
Nice spot, i's need to investigate this further, could be the way react works. Ive created a GitHub Issue for this
|
Looks good 👍 |
|
All good: 👍. |
Creating a quote component
What does this PR do? (please provide any background)
<blockquote>and<q>elementWhat tests does this PR have?
How can be this tested?
npm run testto run all mocha testsgrunt docsand check the example on the UIToolkit docsScreenshots / Screencast
#### What gif best describes how you feel about this work?Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):
Software Engineer or Developer review:
Software Engineer or project guru review: