UXUI-284 Countdown Component #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking SE |
|
Taking Dev |
| var pad = function (number) { | ||
| number = Math.abs(Math.floor(number)); | ||
| if (number > 9) { | ||
| return number; |
There was a problem hiding this comment.
This should be returning a string so that the output of this function is a consistent type. i.e return '' + number;
| this.CountdownManager.start(this.callback); | ||
| this.timer.tick(CountdownManager.countdownInterval); | ||
| assert.equal(this.callback.called, true); | ||
| // expect(this.callback.called).to.be(true); |
|
|
|
I'm happy with this once the above comments have been addressed. Also should the lozenge work be in this PR or should it be in a separate PR? |
|
+1 |
|
Just one minor point, the references to |
|
👍 Looks good dude |
jodiedoubleday
pushed a commit
that referenced
this pull request
Aug 11, 2015
UXUI-284 Countdown Component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? (please provide any background)
What tests does this PR have?
npm testHow can be this tested?
grunt docsfrom a local copy.codeon the docs and change the date to whatever you see fit.Screenshots / Screencast
#### What gif best describes how you feel about this work?Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):
Software Engineer or Developer review:
Software Engineer or project guru review: