PATCH: changing to font icons as a temporary fix to style weather icons #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"We will eventually use our own icons fonts hosted on a CDN" - Would we not eventually move to SVG? I would assume we want to sunset all use of icon fonts in favour of SVG? |
|
Yup wrong wording, changed in PR decription |
|
Taking dev |
|
Looks pretty solid to me 👍 https://cloudup.com/c6wAqyr8XRU |
|
Review 🙌 |
| @@ -2,24 +2,35 @@ | |||
| #Weather | |||
| \*------------------------------------*/ | |||
|
|
|||
| @font-face { | |||
| font-family: 'MeteoconsRegular'; | |||
There was a problem hiding this comment.
linting comment: 4 spaces
|
Couple of really minor linting things, code looks good though 👍. Looking forward to getting it into HEHA! |
|
👍 |
jodiedoubleday
added a commit
that referenced
this pull request
Sep 14, 2015
PATCH: changing to font icons as a temporary fix to style weather icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? (please provide any background)
We were using SVG's as background images on our weather components, however this meant that the colors of the icons couldn't be changed.
What tests does this PR have?
Nothing new
How can this be tested?
grunt builddocsScreenshots / Screencast
#### What gif best describes how you feel about this work?Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):
Software Engineer or Developer review:
Software Engineer or project guru review: