Better debug output #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than logging strings, pass around a debug object that'll contain all of the same information. Print that object once at times.
| request: soapRequest | ||
| } | ||
| }; | ||
| if (coreSettings.debugSoap) coreSettings.logger(debug); |
There was a problem hiding this comment.
Not sure if we should be doing this log here as it'll just get duplicated above but it'll be useful to have it just incase requests never make it back for some odd reason. What do others think?
There was a problem hiding this comment.
If no requests are making it back, we'll have a pretty obvious problem, if it's only some I don't think it'll be obvious from the log output which ones (all the successes log this too, so there'll be a steady baseline amount of output/noise from this line)
added 2 commits
March 30, 2015 15:52
|
+1 |
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug output is pretty printing the json output which isn't ideal when you're trying to write to log files in environments other than development. So this change hands the pretty printing responsibility over to the logging function. The library itself will pass the logging function an object containing the same information it was logging individually.