Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanukkah does not appear in list of holidays #414

Open
brandonbrown5 opened this issue Dec 7, 2023 · 1 comment
Open

Hanukkah does not appear in list of holidays #414

brandonbrown5 opened this issue Dec 7, 2023 · 1 comment

Comments

@brandonbrown5
Copy link

Looking at all holidays in December this year (2023), I noticed that Hanukkah was not included. Is it possible to include Hanukkah in the list of hoildays?

Reproduction:

Holidays.between(Date.new(2023, 12, 1), Date.new(2023, 12, 31))
@brandonbrown5
Copy link
Author

@ppeble @ttwo32
Would you be open to us tackling this problem? Saw this repo has gotten a little stale and wanted to make sure we would be able to merge the changes if we put in the work to add Hanukkah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant