Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep language server protocol support #480

Closed
Yokozuna59 opened this issue Nov 23, 2023 · 3 comments
Closed

deep language server protocol support #480

Yokozuna59 opened this issue Nov 23, 2023 · 3 comments

Comments

@Yokozuna59
Copy link

Hi there! First of all, thanks for your amazing diagraming tool! It really helped me a lot.

But I was wondering, do you have any plans to support more language server features? For example, suggestions, go to definition, go to references, semantic highlighting, etc.

I saw that @Huy-DNA has implemented some of those features in #439, but it was merged into a different branch, not the master. So I'm wondering if it has been dropped or if there is still a plan in mind.

I was able to implement most of those features:

showcase.webm

If you do plan to implement them, then I'm more than happy to help!

@Huy-DNA
Copy link
Member

Huy-DNA commented Nov 24, 2023

Hi, thanks for your interest and effort in helping to improve dbdiagram!
Currently we have moved to a new parser for dbml which is a new package dbml-parse in dbml. For now, we have supported suggestions, go to definition and go to references in dbml-parse/src/services.
There are plenty of room for improvements so we'll definitely appreciate your help.

@NQPhuc NQPhuc closed this as completed Nov 24, 2023
@Yokozuna59
Copy link
Author

@Huy-DNA Awesome! I'm not really familiar with the project yet, but when these features would be available on the website?

@NQPhuc NQPhuc reopened this Nov 24, 2023
@NQPhuc
Copy link
Contributor

NQPhuc commented Nov 24, 2023

@Yokozuna59 We'll release these new services to dbdiagram.io very soon. Thanks

@NQPhuc NQPhuc closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants