Ported SoundBankPlayer to ARC #1
Conversation
| @@ -148,13 +145,13 @@ static void interruptionListener(void* inClientData, UInt32 inInterruptionState) | |||
|
|
|||
| - (void)registerAudioSessionCategory | |||
| { | |||
| UInt32 sessionCategory = kAudioSessionCategory_MediaPlayback; | |||
There was a problem hiding this comment.
I'm sorry, I now see that this part slipped in for me in the commit and is unconnected to porting to ARC, but I think this is a better default because you want to be able to record as well.
|
Looks good, although for the time being I will leave the project non-ARC. Note that the PlayAndRecord category tends to make the playback volume lower. Maybe that only happens when you actually start recording something, but if you're not recording then I'd keep the category at MediaPlayback. This class was written to be a drop-in solution for apps that just want to play audio. If you want to do more than that, then it's actually inappropriate for SoundBankPlayer to mess with the audio session. |
|
fair enough. For this - you only need to change the type of filename to be a char const * instead of an NSString * like I did, but you can leave the release and dealloc calls, etc. |
|
Moved to project to ARC. The latest non-ARC version can be found in the before-arc tag. |
The main thing here is that Buffer had a pointer to NSString, which is forbidden, so I used a cString instead.