Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research/use idle sockets #33

Merged
merged 31 commits into from
Apr 28, 2019
Merged

Conversation

hollodotme
Copy link
Owner

@hollodotme hollodotme commented Apr 26, 2019

Proposed Changes

  • Adding socket status: INIT, IDLE & BUSY to check for idle & reusable sockets
  • Reset response property of Socket class when a new request is performed
  • Do not disconnect & remove socket from list after response was received
  • Remove sockets only from list, if it's not usable anymore (e.g. timed out or closed)
  • Refactor socket list to an internal collection in order to cleanup operations on the socket list
  • Tests for the newly introduced socket methods
  • Tests for the newly introduced socket collection
  • Tests for the re-using of idle sockets

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #33 into development will increase coverage by 6.51%.
The diff coverage is 88.03%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development      #33      +/-   ##
=================================================
+ Coverage          82.45%   88.97%   +6.51%     
- Complexity           178      209      +31     
=================================================
  Files                 13       14       +1     
  Lines                456      517      +61     
=================================================
+ Hits                 376      460      +84     
+ Misses                80       57      -23
Impacted Files Coverage Δ Complexity Δ
src/Client.php 48.57% <58.33%> (+4.66%) 38 <0> (-7) ⬇️
src/Sockets/Socket.php 90.37% <92.1%> (ø) 73 <12> (?)
src/Sockets/SocketCollection.php 98.18% <98.18%> (ø) 26 <26> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9596249...fe4b9c1. Read the comment docs.

@hollodotme hollodotme marked this pull request as ready for review April 28, 2019 17:14
@hollodotme hollodotme merged commit eb06f34 into development Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant