Fix: Disable stylistic ESLint rules (#82)

* Fix: Disable stylistic ESLint rules * Fix: turn off some ESLInt rules covered by TSLint * Other: set tslint.json as jsonc in VS Code * Fix: Disable some rules already handled by TSLint * Other: Allow comments in .eslintrc.json * Breaking: Update @hollowverse/utils * Other: remove unused ignores in .gitignore * Breaking: Add @types/node to package.json * Breaking: Add engines.node to lambda/package.json
hollowverse-archive · May 18, 2018 · 3930df8 · 3930df8
1 parent bd0ab56
commit 3930df8
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 105 deletions.
diff --git a/.gitignore b/.gitignore
@@ -60,20 +60,6 @@ typings/
 .env
 helpers/**/*.js
 helpers/**/*.d.ts
-# Builds
-dist
-
-secrets/**/*
-!secrets/**/*.enc
-!secrets/**/*.d.ts
-
-build.zip
-build
-
-# Elastic Beanstalk Files
-.elasticbeanstalk/*
-!.elasticbeanstalk/*.cfg.yml
-!.elasticbeanstalk/*.global.yml
 
 # Created by Serverless
 .build

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -23,6 +23,8 @@
   "files.associations": {
     "**/.babelrc": "jsonc",
     "**/.babelrc.json": "jsonc",
-    "**/tsconfig.json": "jsonc"
+    "**/tsconfig.json": "jsonc",
+    "**/tslint.json": "jsonc",
+    "**/.eslintrc.json": "jsonc"
   }
 }
diff --git a/clown/common/.gitignore b/clown/common/.gitignore
@@ -38,21 +38,6 @@ node_modules/
 # Yarn Integrity file
 .yarn-integrity
 
-# Builds
-dist
-
-secrets/**/*
-!secrets/**/*.enc
-!secrets/**/*.d.ts
-
-build.zip
-build
-
-# Elastic Beanstalk Files
-.elasticbeanstalk/*
-!.elasticbeanstalk/*.cfg.yml
-!.elasticbeanstalk/*.global.yml
-
 # Created by Serverless
 .build
 .webpack

diff --git a/clown/common/.vscode/settings.json b/clown/common/.vscode/settings.json
@@ -14,7 +14,9 @@
   "files.associations": {
     "**/.babelrc": "jsonc",
     "**/.babelrc.json": "jsonc",
-    "**/tsconfig.json": "jsonc"
+    "**/tslint.json": "jsonc",
+    "**/tsconfig.json": "jsonc",
+    "**/.eslintrc.json": "jsonc"
   },
   "typescript.implementationsCodeLens.enabled": true,
   "typescript.referencesCodeLens.enabled": true,

diff --git a/clown/lambda/package.json b/clown/lambda/package.json
@@ -2,6 +2,10 @@
   "main": "index.js",
   "private": true,
   "dependencies": {
-    "@hollowverse/utils": "^6.0.0"
+    "@types/node": "^8.10.16",
+    "@hollowverse/utils": "^7.0.1"
+  },
+  "engines": {
+    "node": ">= 8.10"
   }
 }
diff --git a/eslint/base/.eslintrc.json b/eslint/base/.eslintrc.json
@@ -4,6 +4,7 @@
   "rules": {
     "max-len": ["error", 120],
     "max-depth": ["error", 4],
+    "arrow-body-style": ["off"],
     "import/prefer-default-export": ["off"],
     "import/no-default-export": ["error"],
     "import/extensions": [

diff --git a/eslint/typescript/.eslintrc.json b/eslint/typescript/.eslintrc.json
@@ -11,7 +11,13 @@
     "no-restricted-syntax": ["off"],
     "no-unused-vars": ["off"],
     "no-restricted-globals": ["off"],
-    "import/first": ["off"]
+    "no-unexpected-require": ["off"],
+    "import/first": ["off"],
+
+    // Already handled by TSLint
+
+    "import/no-dynamic-require": ["off"],
+    "import/no-extraneous-dependencies": ["off"]
   },
   "settings": {
     "import/resolver": {

diff --git a/package.json b/package.json
@@ -52,7 +52,6 @@
   "devDependencies": {
     "@commitlint/cli": "^6.1.3",
     "@hollowverse/clown": "^3.1.1",
-    "@hollowverse/utils": "^6.0.0",
     "@hollowverse/validate-filenames": "^3.0.2",
     "babel-eslint": "^8.2.2",
     "del-cli": "^1.1.0",

diff --git a/yarn.lock b/yarn.lock
@@ -250,21 +250,6 @@
     lodash "^4.17.4"
     sort-keys "^2.0.0"
 
-"@hollowverse/utils@^6.0.0":
-  version "6.0.0"
-  resolved "https://registry.yarnpkg.com/@hollowverse/utils/-/utils-6.0.0.tgz#d9b978531a445f5d031ab72af066424358df1bf0"
-  dependencies:
-    "@babel/polyfill" "^7.0.0-beta.44"
-    "@babel/runtime" "^7.0.0-beta.44"
-    "@types/aws-lambda" "^0.0.34"
-    bluebird "^3.5.1"
-    common-tags "^1.7.2"
-    glob "^7.1.2"
-    jszip "^3.1.4"
-    lodash "^4.17.4"
-    minimatch "^3.0.4"
-    shelljs "^0.7.8"
-
 "@hollowverse/validate-filenames@^3.0.2":
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/@hollowverse/validate-filenames/-/validate-filenames-3.0.2.tgz#60610109b63bed5285f3435e32ce721c5f623f1d"
@@ -366,10 +351,6 @@
     into-stream "^3.1.0"
     lodash "^4.17.4"
 
-"@types/aws-lambda@^0.0.34":
-  version "0.0.34"
-  resolved "https://registry.yarnpkg.com/@types/aws-lambda/-/aws-lambda-0.0.34.tgz#dd6abb59a52dd2b674e9dd8e37de3485ea9cba7d"
-
 JSONStream@^1.0.4:
   version "1.3.2"
   resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.2.tgz#c102371b6ec3a7cf3b847ca00c20bb0fce4c6dea"
@@ -1108,10 +1089,6 @@ core-js@^2.4.0, core-js@^2.5.0, core-js@^2.5.3:
   version "2.5.4"
   resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.4.tgz#f2c8bf181f2a80b92f360121429ce63a2f0aeae0"
 
-core-js@~2.3.0:
-  version "2.3.0"
-  resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.3.0.tgz#fab83fbb0b2d8dc85fa636c4b9d34c75420c6d65"
-
 core-util-is@1.0.2, core-util-is@~1.0.0:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"
@@ -1424,10 +1401,6 @@ es6-promise@^4.0.3:
   version "4.2.4"
   resolved "https://registry.yarnpkg.com/es6-promise/-/es6-promise-4.2.4.tgz#dc4221c2b16518760bd8c39a52d8f356fc00ed29"
 
-es6-promise@~3.0.2:
-  version "3.0.2"
-  resolved "https://registry.yarnpkg.com/es6-promise/-/es6-promise-3.0.2.tgz#010d5858423a5f118979665f46486a95c6ee2bb6"
-
 es6-promisify@^5.0.0:
   version "5.0.0"
   resolved "https://registry.yarnpkg.com/es6-promisify/-/es6-promisify-5.0.0.tgz#5109d62f3e56ea967c4b63505aef08291c8a5203"
@@ -2252,10 +2225,6 @@ ignore@^3.3.3, ignore@^3.3.5:
   version "3.3.7"
   resolved "https://registry.yarnpkg.com/ignore/-/ignore-3.3.7.tgz#612289bfb3c220e186a58118618d5be8c1bab021"
 
-immediate@~3.0.5:
-  version "3.0.6"
-  resolved "https://registry.yarnpkg.com/immediate/-/immediate-3.0.6.tgz#9db1dbd0faf8de6fbe0f5dd5e56bb606280de69b"
-
 import-from@^2.1.0:
   version "2.1.0"
   resolved "https://registry.yarnpkg.com/import-from/-/import-from-2.1.0.tgz#335db7f2a7affd53aaa471d4b8021dee36b7f3b1"
@@ -2287,7 +2256,7 @@ inflight@^1.0.4:
     once "^1.3.0"
     wrappy "1"
 
-inherits@2, inherits@^2.0.1, inherits@^2.0.3, inherits@~2.0.1, inherits@~2.0.3:
+inherits@2, inherits@^2.0.1, inherits@^2.0.3, inherits@~2.0.3:
   version "2.0.3"
   resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de"
 
@@ -2889,16 +2858,6 @@ jsx-ast-utils@^2.0.0, jsx-ast-utils@^2.0.1:
   dependencies:
     array-includes "^3.0.3"
 
-jszip@^3.1.4:
-  version "3.1.5"
-  resolved "https://registry.yarnpkg.com/jszip/-/jszip-3.1.5.tgz#e3c2a6c6d706ac6e603314036d43cd40beefdf37"
-  dependencies:
-    core-js "~2.3.0"
-    es6-promise "~3.0.2"
-    lie "~3.1.0"
-    pako "~1.0.2"
-    readable-stream "~2.0.6"
-
 kind-of@^3.0.2, kind-of@^3.0.3, kind-of@^3.2.0:
   version "3.2.2"
   resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-3.2.2.tgz#31ea21a734bab9bbb0f32466d893aea51e4a3c64"
@@ -2950,12 +2909,6 @@ levn@^0.3.0, levn@~0.3.0:
     prelude-ls "~1.1.2"
     type-check "~0.3.2"
 
-lie@~3.1.0:
-  version "3.1.1"
-  resolved "https://registry.yarnpkg.com/lie/-/lie-3.1.1.tgz#9a436b2cc7746ca59de7a41fa469b3efb76bd87e"
-  dependencies:
-    immediate "~3.0.5"
-
 lint-staged@^7.0.5:
   version "7.0.5"
   resolved "https://registry.yarnpkg.com/lint-staged/-/lint-staged-7.0.5.tgz#1ed04c4bb2013579a3d4df4dfe0f2ea1cd988fad"
@@ -3633,10 +3586,6 @@ package-json@^4.0.0:
     registry-url "^3.0.3"
     semver "^5.1.0"
 
-pako@~1.0.2:
-  version "1.0.6"
-  resolved "https://registry.yarnpkg.com/pako/-/pako-1.0.6.tgz#0101211baa70c4bca4a0f63f2206e97b7dfaf258"
-
 parse-domain@^2.0.0:
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/parse-domain/-/parse-domain-2.0.0.tgz#e9f42f697c30f7c2051dc5c55ff4d8a80da7943c"
@@ -3817,10 +3766,6 @@ pretty-format@^22.4.3:
     ansi-regex "^3.0.0"
     ansi-styles "^3.2.0"
 
-process-nextick-args@~1.0.6:
-  version "1.0.7"
-  resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-1.0.7.tgz#150e20b756590ad3f91093f25a4f2ad8bff30ba3"
-
 process-nextick-args@~2.0.0:
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-2.0.0.tgz#a37d732f4271b4ab1ad070d35508e8290788ffaa"
@@ -3962,17 +3907,6 @@ readable-stream@^2.0.0, readable-stream@^2.0.2, readable-stream@^2.1.5, readable
     string_decoder "~1.1.1"
     util-deprecate "~1.0.1"
 
-readable-stream@~2.0.6:
-  version "2.0.6"
-  resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.0.6.tgz#8f90341e68a53ccc928788dacfcd11b36eb9b78e"
-  dependencies:
-    core-util-is "~1.0.0"
-    inherits "~2.0.1"
-    isarray "~1.0.0"
-    process-nextick-args "~1.0.6"
-    string_decoder "~0.10.x"
-    util-deprecate "~1.0.1"
-
 rechoir@^0.6.2:
   version "0.6.2"
   resolved "https://registry.yarnpkg.com/rechoir/-/rechoir-0.6.2.tgz#85204b54dba82d5742e28c96756ef43af50e3384"
@@ -4562,10 +4496,6 @@ string.prototype.padend@^3.0.0:
     es-abstract "^1.4.3"
     function-bind "^1.0.2"
 
-string_decoder@~0.10.x:
-  version "0.10.31"
-  resolved "https://registry.yarnpkg.com/string_decoder/-/string_decoder-0.10.31.tgz#62e203bc41766c6c28c9fc84301dab1c5310fa94"
-
 string_decoder@~1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/string_decoder/-/string_decoder-1.1.1.tgz#9cf1611ba62685d7030ae9e4ba34149c3af03fc8"