Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min and maximum argumet. #70

Closed
wants to merge 2 commits into from
Closed

Conversation

talwrii
Copy link

@talwrii talwrii commented Dec 16, 2013

Min and maximum arguments - kind of similar to another pull request - but deals with edge cases a little better and doesn't use environment variables.

@holman
Copy link
Owner

holman commented Dec 22, 2014

Going to go with #54 instead here.

@holman holman closed this Dec 22, 2014
@sindresorhus
Copy link

@holman to quote you in #54:

Not a huge fan of using environment variables here

Can you reconsider this instead? Using flags would be a more natural solution here.
Though --min/--max instead of -m/-M would be better.

@davidcelis
Copy link

I'd also ask for reconsideration here; If the environment variable solution had array issues, perhaps this could be revisited?

@holman
Copy link
Owner

holman commented Jan 16, 2015

I'm mostly just not into the additional code that comes with it.

@davidcelis
Copy link

That's fair; thanks for the honesty. In the meantime, if anybody else needs this for some utility like I did, I brought in @talwrii's changes into my own fork and added a homebrew formula to install it. brew tap davidcelis/spark && brew install davidcelis/spark/spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants