Skip to content

Commit

Permalink
Fixed bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
guillemcordoba committed May 14, 2024
1 parent bb669a9 commit 7017a26
Showing 1 changed file with 27 additions and 4 deletions.
31 changes: 27 additions & 4 deletions crates/npm_scaffolding_utils/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,12 @@ pub fn add_npm_dev_dependency_to_package(
));
};

let mut stub = serde_json::Value::Object(Map::new());
if !map.contains_key("devDependencies") {
let stub = serde_json::Value::Object(Map::new());
map.insert("devDependencies".into(), stub);
}

let dependencies_value = map.get_mut("devDependencies").unwrap_or(&mut stub);
let dependencies_value = map.get_mut("devDependencies").unwrap();

let Some(dependencies) = dependencies_value.as_object_mut() else {
return Err(NpmScaffoldingUtilsError::MalformedJsonError(
Expand Down Expand Up @@ -222,9 +225,12 @@ pub fn add_npm_script_to_package(
));
};

let mut stub = serde_json::Value::Object(Map::new());
if !map.contains_key("scripts") {
let stub = serde_json::Value::Object(Map::new());
map.insert("scripts".into(), stub);
}

let scripts_value = map.get_mut("scripts").unwrap_or(&mut stub);
let scripts_value = map.get_mut("scripts").unwrap();

let Some(scripts) = scripts_value.as_object_mut() else {
return Err(NpmScaffoldingUtilsError::MalformedJsonError(
Expand Down Expand Up @@ -344,6 +350,23 @@ mod tests {
);
}

#[test]
fn single_package_dev_dependency_test() {
let content =
add_npm_dev_dependency_to_package(&(PathBuf::from("package.json"),empty_package_json("single")), &String::from("some-dep"), &String::from("some-url")) .unwrap();

assert_eq!(
content,
r#"{
"name": "single",
"dependencies": {},
"devDependencies": {
"some-dep": "some-url"
}
}"#
);
}

fn empty_package_json(package_name: &str) -> String {
format!(
r#"{{
Expand Down

0 comments on commit 7017a26

Please sign in to comment.