Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hc-utils method name #20

Merged
merged 3 commits into from
Jul 20, 2022
Merged

update hc-utils method name #20

merged 3 commits into from
Jul 20, 2022

Conversation

JettTech
Copy link
Contributor

Updates:

  • replaces hc-utils get_header with new get_action method name

NB: Depends on hc-utils PR #32

@JettTech JettTech changed the title update hc-utils method name [wip] update hc-utils method name Jul 18, 2022
Base automatically changed from v0.0.138 to develop July 18, 2022 16:05
@JettTech JettTech changed the title [wip] update hc-utils method name update hc-utils method name Jul 18, 2022
@JettTech JettTech requested a review from zo-el July 18, 2022 16:37
zo-el
zo-el requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the crate to point to a new release

@JettTech
Copy link
Contributor Author

This PR is dependent on hc utils pr #32 . Once that pr is merged and released, I will point to that release. 👍

@JettTech JettTech requested a review from zo-el July 19, 2022 21:30
@zo-el zo-el changed the base branch from develop to v0.0.138 July 19, 2022 21:58
zo-el
zo-el approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving this before its pointing to the right hc-utils release..

Also, I have changed the base to the v0.0.138 branch which needs to be pushed to develop too. The reason for doing so is that all our DNA's uses git branches for hc-zome-lib

@JettTech JettTech changed the base branch from v0.0.138 to develop July 20, 2022 06:06
@JettTech
Copy link
Contributor Author

JettTech commented Jul 20, 2022 •
edited
Loading

NB: switched base branch back to develop to trigger ci tests. Will switch back once the ci shows the passing tests.

@JettTech JettTech changed the base branch from develop to v0.0.138 July 20, 2022 06:37
@JettTech JettTech merged commit e9e8749 into v0.0.138 Jul 20, 2022
@JettTech JettTech deleted the update-hc-utils-call branch July 20, 2022 06:38
@JettTech JettTech mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zo-el zo-el zo-el approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JettTech @zo-el